[lworld] RFR: 8368875: [lworld] UseParallelGC fails null narrow klass assertion failure
Coleen Phillimore
coleenp at openjdk.org
Fri Oct 3 18:01:33 UTC 2025
On Fri, 3 Oct 2025 14:27:13 GMT, Paul Hübner <phubner at openjdk.org> wrote:
>> The other way around, `is_larval_state` implies `is_inline_type` because only value classes instances can be in a larval state.
>
> Thanks @fparain, I mixed it up when writing it down. I knew that, I promise 😅.
>
> I think it would be good to introduce an `is_valhalla_concept` (naming may vary) which ORs the larval, inline type, flat array and null free array bit masks into a single mask. That way we can check it in just one call, which is imo easier to read. Thoughts?
Maybe we can consider this as a further enhancement. If we add valhalla bits (although I think we're out of bits), this would make sense to collect them all. I think all of this is probably optimized to one load and compare since it's inline.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1655#discussion_r2402843119
More information about the valhalla-dev
mailing list