RFR: 8368467: [lworld] Add new flag generation for jimage to support preview mode [v3]
David Beaumont
duke at openjdk.org
Wed Oct 8 19:10:31 UTC 2025
On Fri, 26 Sep 2025 19:30:11 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> David Beaumont has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains four new commits since the last revision:
>>
>> - Restoring lost changes and updating some comments.
>> - add system property guard to preview mode
>> - jimage writer changes to support preview mode.
>>
>> * Remove TODOs now jimage version is bumped
>> * jimage writer changes to support preview mode.
>> - Manually deleting ImageReaderFactory (it returned somehow)
>
> src/java.base/share/classes/jdk/internal/jimage/PreviewMode.java line 68:
>
>> 66: if (!ENABLE_PREVIEW_MODE) {
>> 67: return false;
>> 68: }
>
> As commented in the 1618 PR, the extra subclasses caused by the overrides can be replaced by the resolve method switching on `ordinal()`.
Great idea, thanks.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1621#discussion_r2414778951
More information about the valhalla-dev
mailing list