[lworld] RFR: 8366093: [lworld] Add preview mode to C++ classloader [v2]
Roger Riggs
rriggs at openjdk.org
Tue Oct 14 18:04:55 UTC 2025
On Tue, 14 Oct 2025 16:00:03 GMT, David Beaumont <duke at openjdk.org> wrote:
>> The assert is live, so the comment can be removed. non-empty module name seems like the correct assertion.
>
> name_len and module_name_len are two different things though. The assert for module_name_len is not live.
> Does module_name_len perhaps mean something in the context of code not in any module?
> The code below would generate an unobtainable path with '//' in (not present in the jimage, but lookup will progress the same as any other non-existent path).
> I'll raise a PR for it and see if it can be enabled or (if module names can be empty) be just shortcut and return `0L` if it happens.
ok, a separate PR is a good idea to resolve that.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1618#discussion_r2430020063
More information about the valhalla-dev
mailing list