[lworld] RFR: 8369185: [lworld] Wrong execution in TestMismatchHandling after regenerating TestMismatchHandling.jcod [v2]

Marc Chevalier mchevalier at openjdk.org
Wed Oct 15 13:08:17 UTC 2025


On Wed, 15 Oct 2025 05:30:32 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - comment
>>  - review
>
> src/hotspot/share/code/dependencies.hpp line 120:
> 
>> 118:     // was assumed to be callable with the scalar calling convention.
>> 119:     // In case of a mismatch, because of future class loading, the
>> 120:     // nmethod must be recompiled to use the non-scalar calling convention.
> 
> This comment is a bit imprecise. The problem is that **some** argument of this method was assumed to be always passed in scalarized form. Due to a mismatch with two super methods (one assuming scalarized and one assuming non-scalarized), all **callers** of this method (via virtual calls) now need to be recompiled. Right? Maybe refer to the code in `CompiledEntrySignature::compute_calling_conventions` for details.

I've tried to improve it, largely based on this comment.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1677#discussion_r2432484875


More information about the valhalla-dev mailing list