[lworld] RFR: 8369437: [lworld] Split multiple @run statements in compiler tests into separate @test blocks [v2]
Christian Hagedorn
chagedorn at openjdk.org
Wed Oct 15 14:04:26 UTC 2025
On Wed, 15 Oct 2025 13:16:02 GMT, Paul Hübner <phubner at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review Paul
>
> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestArrayNullMarkers.java line 63:
>
>> 61:
>> 62: /*
>> 63: * @test id=nAVF
>
> Nitpick/FYI: switching from kebab case to camel case. I don't think this matters at all but wanted to point it out just in case.
Good observation! I used it for "non-atomic" because it still belongs to the "A" and I did not want to confuse it with "N" for Nullable. It's a little unfortunate, though.
> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestUnexpectedMemBar.java line 38:
>
>> 36:
>> 37: /*
>> 38: * @test id=AII-
>
> I think trailing `-` are awkward? Or is there a convention/reason for this?
Good catch! Fixed.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1681#discussion_r2432660376
PR Review Comment: https://git.openjdk.org/valhalla/pull/1681#discussion_r2432664035
More information about the valhalla-dev
mailing list