[lworld] RFR: 8368988: [lworld] Rename classes in valhalla/inlinetypes to be distinct [v2]
Marc Chevalier
mchevalier at openjdk.org
Tue Oct 21 07:46:17 UTC 2025
> Various cleanup in test package `compiler.valhalla.inlinetypes`:
> - rename duplicated classes so that IDEs are nice, resolve correctly. New names are a bit... arbitrary. I'm happy to rename name if anyone has opinions. When writing new tests, let's prefer nested classes if we can.
> - add `package compiler.valhalla.inlinetypes;` where it was missing. IDEs like that, and I vaguely remember we should.
> - fix flags to take the new path into account, new package, or class renaming. Please, try to pay attention to that: I've did multiple passes to catch'em all, but this is easy to miss.
> - remove some useless `import`.
> - some few typos in comments.
> - maybe more?
>
> Thanks,
> Marc
Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
More consistent naming convention
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/1683/files
- new: https://git.openjdk.org/valhalla/pull/1683/files/140916f2..306d2f9a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=1683&range=01
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1683&range=00-01
Stats: 1055 lines in 24 files changed: 0 ins; 0 del; 1055 mod
Patch: https://git.openjdk.org/valhalla/pull/1683.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1683/head:pull/1683
PR: https://git.openjdk.org/valhalla/pull/1683
More information about the valhalla-dev
mailing list