RFR: 8368333: [lworld] Add preview mode to ImageReader and JRT file-system [v6]

Roger Riggs rriggs at openjdk.org
Wed Oct 22 19:41:25 UTC 2025


On Wed, 22 Oct 2025 19:25:59 GMT, David Beaumont <duke at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/jimage/ModuleReference.java line 133:
>> 
>>> 131: 
>>> 132:     /** Returns whether this reference exists only in preview mode. */
>>> 133:     public boolean isPreviewOnly() {
>> 
>> Pick either PreviewOnly or hasNormal and use consistently. (Even if one is the opposite of the other).
>
> They are NOT opposites. It is not possible to use only one or these flags and continue to be logically correct.

Hmm, the implementation of `isPreviewOnly()` is exactly `!hasNormalVersion(flags)`

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1619#discussion_r2453155191


More information about the valhalla-dev mailing list