[lworld] RFR: 8370450: [lworld] Alternate implementation of the substitutability test method [v2]

[Frederic Parain]

On Wed, 22 Oct 2025 21:15:58 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge remote-tracking branch 'upstream/lworld' into new_acmp
>>  - Add alternate version of the substitutability method
>
> src/hotspot/share/classfile/fieldLayoutBuilder.hpp line 289:
> 
>> 287:   FieldLayout* _layout;
>> 288:   FieldLayout* _static_layout;
>> 289:   GrowableArray<Pair<int,int>>* _nonoop_acmp_map ;
> 
> Suggestion:
> 
>   GrowableArray<Pair<int,int>>* _nonoop_acmp_map;

Fixed

> src/hotspot/share/oops/instanceKlass.hpp line 650:
> 
>> 648:   ReferenceType reference_type() const     { return (ReferenceType)_reference_type; }
>> 649: 
>> 650:   int acmp_maps_offset() const { return _acmp_maps_offset; }
> 
> Probably assert `_acmp_maps_offset != 0`

Fixed

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1695#discussion_r2457247239
PR Review Comment: https://git.openjdk.org/valhalla/pull/1695#discussion_r2457246135