[lworld] RFR: 8369921: [lworld] Remove caches of primitive wrapper classes [v2]

Chen Liang liach at openjdk.org
Thu Oct 23 23:55:25 UTC 2025


On Mon, 20 Oct 2025 15:11:47 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review suggestions to put constant locals into non-preview block
>>   and use the same code pattern for Boolean.valueOf.
>>   Update some tests to run in --enable-preview as well as non-preview.
>
> src/java.base/share/classes/java/lang/Short.java line 301:
> 
>> 299:     public static Short valueOf(short s) {
>> 300:         final int offset = 128;
>> 301:         int sAsInt = s;
> 
> Same remark, I recommend moving this into the preview feature check block.

I think you missed the `sAsInt` variable.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1685#discussion_r2457996306


More information about the valhalla-dev mailing list