[lworld] RFR: 8368333: [lworld] Add preview mode to ImageReader and JRT file-system [v9]
Roger Riggs
rriggs at openjdk.org
Wed Oct 29 21:15:41 UTC 2025
On Fri, 24 Oct 2025 17:05:58 GMT, David Beaumont <duke at openjdk.org> wrote:
>> Java changes for supporting preview mode when preview mode resources (with new location flags) are available.
>>
>> At the moment, this code will operate on non-preview jimage files (1.0) and act as if no preview resources are available by virtue of the default value for missing attributes and package flags being zero (which matches jimage 1.0).
>>
>> This should be reviewed on top of https://github.com/openjdk/valhalla/pull/1618
>
> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>
> feedback changes
test/jdk/jdk/internal/jimage/ImageReaderTest.java line 1:
> 1: /*
It seems odd to only have PreviewMode.DISABLED tests in ImageReaderTest.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1619#discussion_r2471002319
More information about the valhalla-dev
mailing list