[lworld] RFR: 8368333: [lworld] Add preview mode to ImageReader and JRT file-system [v10]

David Beaumont duke at openjdk.org
Thu Oct 30 12:09:19 UTC 2025


On Wed, 29 Oct 2025 15:46:25 GMT, David Beaumont <duke at openjdk.org> wrote:

>> Java changes for supporting preview mode when preview mode resources (with new location flags) are available.
>> 
>> At the moment, this code will operate on non-preview jimage files (1.0) and act as if no preview resources are available by virtue of the default value for missing attributes and package flags being zero (which matches jimage 1.0).
>> 
>> This should be reviewed on top of https://github.com/openjdk/valhalla/pull/1618
>
> David Beaumont has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - remove ImageReaderFactory.java (again)
>  - Reapplying feedback changes.

I'll have a think about the safety of removing the preview only entries after the directories are completed (you're probably right about that, and I think it's safe wrt syncrhonisation etc.). Good point.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1619#issuecomment-3467679795


More information about the valhalla-dev mailing list