[lworld] RFR: 8364095: [lworld] AccessFlags location and release need futher work for Valhalla (IDENTITY and SUPER) [v2]

[Maurizio Cimadamore]

On Thu, 28 Aug 2025 23:03:11 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Improve access flag reflection for preview on/off.
>> 
>> In this process, I noted javac is incorrectly injecting ACC_IDENTITY to 69.0 class' `InnerClasses` attribute and fixed that.
>> 
>> There is still some inconsistency, such as implying ACC_IDENTITY when preview is on for classes. Don't know if we have discussed on this yet.
>> 
>> No new test failures.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Years

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java line 3348:

> 3346:             flags |= MODULE;
> 3347:         }
> 3348:         if (((flags & ACC_IDENTITY) != 0 && !isMigratedValueClass(flags))

do we still need the `isMigratedValueClass` ? Aren't migrated value classes treated the same as ordinary value classes thanks to the work we did to load different classfiles based on preview-ness?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1533#discussion_r2313605382