[lworld] RFR: 8364095: [lworld] AccessFlags location and release need futher work for Valhalla (IDENTITY and SUPER) [v3]

Chen Liang liach at openjdk.org
Wed Sep 3 15:58:04 UTC 2025


> Improve access flag reflection for preview on/off.
> 
> In this process, I noted javac is incorrectly injecting ACC_IDENTITY to 69.0 class' `InnerClasses` attribute and fixed that.
> 
> There is still some inconsistency, such as implying ACC_IDENTITY when preview is on for classes. Don't know if we have discussed on this yet.
> 
> No new test failures.

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - markedPreview handling
 - Merge branch 'lworld' of https://github.com/openjdk/valhalla into fix/preview-reflects
 - Years
 - Stage
 - Stage
 - Trivial
 - Unit test
 - Fix identity flag missing for preview inner classes
 - Stage
 - Fixes
 - ... and 1 more: https://git.openjdk.org/valhalla/compare/4caba109...94ee7a1e

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/1533/files
  - new: https://git.openjdk.org/valhalla/pull/1533/files/62ed7b13..94ee7a1e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1533&range=02
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1533&range=01-02

  Stats: 69778 lines in 1121 files changed: 42679 ins; 16925 del; 10174 mod
  Patch: https://git.openjdk.org/valhalla/pull/1533.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1533/head:pull/1533

PR: https://git.openjdk.org/valhalla/pull/1533


More information about the valhalla-dev mailing list