[lworld] RFR: 8364095: [lworld] AccessFlags location and release need futher work for Valhalla (IDENTITY and SUPER) [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Sep 3 16:07:00 UTC 2025
On Wed, 3 Sep 2025 15:57:09 GMT, Chen Liang <liach at openjdk.org> wrote:
>> ACC_ ones are bit masks, and distinguishing them is meaningless. AccessFlag.IDENTITY and AccessFlag.SUPER are the actual differing ones. Validation of access flags by version requires somewhat invasive changes to the ClassFile API, so is not included in this patch.
>>
>> Reminder, this class building is completely in non-preview. There is no point talking about identity here.
>
> We can track making LMF/MHP value classes in https://bugs.openjdk.org/browse/JDK-8205668
> ACC_ ones are bit masks, and distinguishing them is meaningless. AccessFlag.IDENTITY and AccessFlag.SUPER are the actual differing ones. Validation of access flags by version requires somewhat invasive changes to the ClassFile API, so is not included in this patch.
>
> Reminder, this class building is completely in non-preview. There is no point talking about identity here.
Ok, I got confused, thought the code was using AccessFlag.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1533#discussion_r2319443201
More information about the valhalla-dev
mailing list