[lworld] RFR: 8364095: [lworld] AccessFlags location and release need futher work for Valhalla (IDENTITY and SUPER) [v3]

Chen Liang liach at openjdk.org
Wed Sep 3 21:04:05 UTC 2025


On Wed, 3 Sep 2025 15:58:04 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Improve access flag reflection for preview on/off.
>> 
>> In this process, I noted javac is incorrectly injecting ACC_IDENTITY to 69.0 class' `InnerClasses` attribute and fixed that.
>> 
>> There is still some inconsistency, such as implying ACC_IDENTITY when preview is on for classes. Don't know if we have discussed on this yet.
>> 
>> No new test failures.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
> 
>  - markedPreview handling
>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into fix/preview-reflects
>  - Years
>  - Stage
>  - Stage
>  - Trivial
>  - Unit test
>  - Fix identity flag missing for preview inner classes
>  - Stage
>  - Fixes
>  - ... and 1 more: https://git.openjdk.org/valhalla/compare/e4fa5664...94ee7a1e

Thanks for the reviews! This will fix javap and facilitate further development, and there's no new failure, so I will go ahead and integrate.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/1533#issuecomment-3250787597


More information about the valhalla-dev mailing list