[lworld] RFR: 8366440: [lworld] Two tests broken with JDK-8364483

Paul Hübner phubner at openjdk.org
Thu Sep 4 13:03:08 UTC 2025


On Thu, 4 Sep 2025 12:41:00 GMT, Paul Hübner <phubner at openjdk.org> wrote:

>> I added some logging and fixed the tests so that one doesn't rely on a migrated class in java.base to throw a VerifyError (will make a parallel fix to this test in mainline).  The other, I changed the logging message that it is looking for. More tests in this area will be added.
>> Tested locally.
>
> src/hotspot/share/classfile/classFileParser.cpp line 6234:
> 
>> 6232:           // Just poking the system dictionary to see if the class has already be loaded. Looking for migrated classes
>> 6233:           // used when --enable-preview when jdk isn't compiled with --enable-preview so doesn't include LoadableDescriptors.
>> 6234:           // This is temporary.
> 
> I was talking to Simms earlier and we think we should have a classfile check (i.e. ensure we are running whatever major + preview we are on at the moment), and then disable the whole loadabledescriptor functionality if the version doesn't match up. When we do this, we should probably consider that here as well. What do you think?

Just to clarify, this PR is fine as-is but do you agree that we should include this part of code if that classfile checking manifests itself?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1544#discussion_r2322055509


More information about the valhalla-dev mailing list