[lworld] RFR: 8366705: [lworld] Re-work of arrays meta-data [v4]

[Frederic Parain]

On Wed, 3 Sep 2025 16:43:14 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 67 commits:
>> 
>>  - Merge branch 'array_klasses' of github.com:fparain/valhalla into array_klasses
>>  - Forgot a TODO
>>  - Small cleanup
>>  - Merge remote-tracking branch 'upstream/lworld' into array_klasses
>>  - Moved get_Klass() back to protected and updated usages
>>  - Merge branch 'array_klasses' of github.com:fparain/valhalla into array_klasses
>>  - Linked TODOs to JDK-8366668
>>  - Multidim array fix
>>  - Cleanup T_FLAT_ELEMENT related code
>>  - Fix for isAssignableFrom + tests
>>  - ... and 57 more: https://git.openjdk.org/valhalla/compare/22e9d5f5...527a17b6
>
> src/hotspot/share/memory/universe.hpp line 32:
> 
>> 30: #include "oops/array.hpp"
>> 31: #include "oops/oopHandle.hpp"
>> 32: #include "oops/refArrayKlass.hpp"
> 
> Should be included in the .cpp file instead?  We could fix this later though.

Fixed.

> src/hotspot/share/oops/constantPool.cpp line 196:
> 
>> 194: oop ConstantPool::set_resolved_reference_at(int index, oop new_result) {
>> 195:   assert(oopDesc::is_oop_or_null(new_result), "Must be oop");
>> 196:   // return resolved_references()->replace_if_null(index, new_result);
> 
> Can remove the commented out line.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1452#discussion_r2323247203
PR Review Comment: https://git.openjdk.org/valhalla/pull/1452#discussion_r2323249118