[lworld] RFR: 8294051: [lworld] runtime/AccModule/ConstModule.java fails with incorrect error message [v2]

Coleen Phillimore coleenp at openjdk.org
Mon Sep 8 17:51:28 UTC 2025


On Mon, 8 Sep 2025 16:12:44 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove extra error message printing for inner classes not in mainline.
>
> src/hotspot/share/classfile/classFileParser.cpp line 4465:
> 
>> 4463:       "Illegal class modifiers in class %s%s: 0x%X",
>> 4464:       _class_name->as_C_string(), class_note, flags
>> 4465:     );
> 
> By removing the special handling of inner classes, the exception will report the access flag issue on the wrong class. This is going to make debugging/troubleshooting harder.

This is something we don't have in mainline.  I can add it there instead and it'll get merged in here.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1550#discussion_r2330929075


More information about the valhalla-dev mailing list