[lworld] RFR: 8367263: [lworld] fix compiler/valhalla/inlinetypes/TestIntrinsics.java after current merges of JDK-8352737 and JDK-8366705
Tobias Hartmann
thartmann at openjdk.org
Wed Sep 10 07:03:48 UTC 2025
On Wed, 10 Sep 2025 06:46:08 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:
> TEST64_LAYOUT = U.arrayLayout(TEST64_ARRAY.getClass());
>
> is not correct anymore since [JDK-8366705](https://bugs.openjdk.org/browse/JDK-8366705) as the layout is no longer a class property, but an instance property (if I understood right)
>
> Weirdly enough, code like
> ```
> U.arrayBaseOffset(TEST64_ARRAY.getClass());
> U.arrayIndexScale(TEST64_ARRAY.getClass());
>
> got also their `.getClass()` removed in [JDK-8366705](https://bugs.openjdk.org/browse/JDK-8366705):
> https://github.com/openjdk/valhalla/blob/0817750d434463a606523ac03b5461802f0328e1/test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestIntrinsics.java#L650-L654
> but there the compiler wasn't yelling at me. Is it overloaded and it works with instance or class, and the instance overload will just query the class. Not sure... I'm still removing it!
>
> Thanks,
> Marc
Looks good to me. Thanks for quickly fixing this!
-------------
Marked as reviewed by thartmann (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/1559#pullrequestreview-3204699778
More information about the valhalla-dev
mailing list