[lworld] RFR: 8367156: [lworld] MacroAssembler::remove_frame hits "Field too big for insn" [v2]

[Marc Chevalier]

On Fri, 12 Sep 2025 16:05:40 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add test
>
> test/hotspot/jtreg/compiler/valhalla/inlinetypes/RepairStackWithBigFrame.java line 35:
> 
>> 33:  *          increment and rfp at the same time, since it only has a 7 bit offset.
>> 34:  *          We use two ldr with 9-bit offsets instead.
>> 35:  * @library /test/lib /
> 
> Do you really need this? You do not seem to use anything from the library.

I thought so too, and I tried without and it doesn't work. I'm using actually `MyValue1` that is defined in the same package, as we do in a lot of valhalla tests. And this one include a lot of things that needs both these paths (I've tried with each alone).

> test/hotspot/jtreg/compiler/valhalla/inlinetypes/RepairStackWithBigFrame.java line 43:
> 
>> 41:  *      -XX:CompileCommand=compileonly,compiler.valhalla.inlinetypes.RepairStackWithBigFrame::test
>> 42:  *      compiler.valhalla.inlinetypes.RepairStackWithBigFrame
>> 43:  * @run main/othervm compiler.valhalla.inlinetypes.RepairStackWithBigFrame
> 
> Can be changed to `main`:
> Suggestion:
> 
>  * @run main compiler.valhalla.inlinetypes.RepairStackWithBigFrame

Right. Done.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1575#discussion_r2344743110
PR Review Comment: https://git.openjdk.org/valhalla/pull/1575#discussion_r2344751307