[lworld] RFR: 8337547: Add LoadableDescriptors to comments for class loading
Coleen Phillimore
coleenp at openjdk.org
Wed Sep 17 20:26:38 UTC 2025
On Wed, 17 Sep 2025 13:38:41 GMT, Frederic Parain <fparain at openjdk.org> wrote:
>> src/hotspot/share/classfile/systemDictionary.cpp line 479:
>>
>>> 477: MutexLocker mu(THREAD, SystemDictionary_lock);
>>> 478:
>>> 479: // Must check ClassCircularity before resolving next_name (superclass, interface or LoadableDescriptor class).
>>
>> Could we say "superclass, interface or field type" in order to cover both the loads triggered by the LoadableDescriptors attribute and the loads triggered by the null-restriction annotation?
>> It applies to the comment at line 503 too.
>
> "field type" is not sufficient either, because the LoadableDescriptors attribute is also used to speculative pre-load argument types.
> Any thought on a better name ?
Thank you - I very much want this comment to be accurate.
Maybe we don't need to say "LoadableDescriptors" here since that's the mechanism.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1594#discussion_r2356682035
More information about the valhalla-dev
mailing list