[lworld] RFR: 8337547: Add LoadableDescriptors to comments for class loading
Coleen Phillimore
coleenp at openjdk.org
Wed Sep 17 20:26:40 UTC 2025
On Tue, 16 Sep 2025 22:16:34 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> This change adds comments for LoadableDescriptors for inline field layout processing to the class loading comments. The other changes are to make the valhalla version of placeholders and systemDictionary match what is in mainline. In mainline, interface and super class calls resolve_super_or_fail, otherwise we call resolve_with_circularity_detection. There are some other comments in mainline in these files that aren't great, that are not addressed here in the Valhalla version.
> Tested with tier1 locally.
src/hotspot/share/classfile/systemDictionary.cpp line 503:
> 501: }
> 502:
> 503: // Resolve the superclass, superinterface or specified LoadableDescriptor class, and check results on return.
Suggestion:
// Resolve the superclass, superinterface, field type or speculatively preloaded argument types and check results on return.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/1594#discussion_r2356684185
More information about the valhalla-dev
mailing list