[lworld] RFR: 8270527: [lworld] markWord::print_on() needs to reflect the additional Valhalla mark word bits [v2]

[David Simms]

On Mon, 22 Sep 2025 12:07:46 GMT, Paul Hübner <phubner at openjdk.org> wrote:

>> Hi all,
>> 
>> This adds debug information to the `markWord::print_on` method for the Valhalla bits. The existing unit tests have been augmented.
>> 
>> Testing: tier 1.
>
> Paul Hübner has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Take in reviewer comments

Minor comment on wording of monitor, otherwise looks good

Marked as reviewed by dsimms (Committer).

src/hotspot/share/oops/markWord.cpp line 75:

> 73:   } else if (has_monitor()) {  // last bits = 10
> 74:     // have to check has_monitor() before is_locked()
> 75:     // Valhalla: inline types/arrays can't be monitored

"can not possess an object monitor" ?

-------------

PR Review: https://git.openjdk.org/valhalla/pull/1588#pullrequestreview-3252225235
PR Review: https://git.openjdk.org/valhalla/pull/1588#pullrequestreview-3252251348
PR Review Comment: https://git.openjdk.org/valhalla/pull/1588#discussion_r2367936123