[lworld] RFR: 8368099: [lworld] Crash in frame::sender_for_compiled_frame while processing JFR sampling request

[Patricio Chilano Mateo]

Reconstructing a synthetic compiled frame when processing a sample request at a poll on return doesn’t work for frames that need stack repair. The stack walking code will read the frame size from the stack, but the memory has already been overwritten by the SafepointBlob frame. See comments in JBS issue for full details.

This patch skips the attempt to create this synthetic frame in case the frame needs stack repair. This fixes the crash but doesn't handle the safepoint bias issue. A more permanent solution will be required for that.

I tested the patch along the fix for 8368002 and verified that Jetty.java doesn’t crash anymore.

Thanks,
Patricio

-------------

Commit messages:
 - skip frames that need stack repair

Changes: https://git.openjdk.org/valhalla/pull/1610/files
  Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=1610&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8368099
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/valhalla/pull/1610.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1610/head:pull/1610

PR: https://git.openjdk.org/valhalla/pull/1610