[lworld] RFR: 8375441: [lworld] C2: assert(is_instance()) failed: bad cast [v3]

[Quan Anh Mai]

On Wed, 4 Feb 2026 12:17:02 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

>> src/hotspot/share/ci/ciInstance.cpp line 65:
>> 
>>> 63: // ciInstance::field_value_impl
>>> 64: ciConstant ciInstance::field_value_impl(ciField* field) {
>>> 65:   BasicType field_btype = field->type()->basic_type();
>> 
>> Just a very little nitpick: We often call the `BasicType` of something `bt`.
>
> I'm fine renaming it, it was just like that before and I've kept it. But I like that it mentions of what it is the basic type. I've seen things as `bt2` and wasn't thrilled. Is `field_bt` fine for you (or `bt_field`)? Anyway, there aren't that many stuff going on in this method, so I'd be fine with a simple `bt`.

`field_bt` seems to be the choice most consistent with other usages.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/1923#discussion_r2763734433