[lworld] RFR: 8377327: [lworld] SA tests fail with --enable-preview
Frederic Parain
fparain at openjdk.org
Mon Feb 9 21:50:56 UTC 2026
On Fri, 6 Feb 2026 18:29:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> This set of SA tests fail because SA tries to parse field layouts. With Valhalla there is new field info in the field stream, which is used when --enable-preview is used since some fields are flattened. This adds minimal support for that.
>
> Tested with tier1-4.
LGTM
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/FieldType.java line 53:
> 51: break; // Ok. signature char known
> 52: default:
> 53: this.first = 'V'; // It's a value type.
I don't understand the purpose of this line.
In signature format, `V` means void, not value type.
And value types are encoded with a L; envelope like all classes.
-------------
Marked as reviewed by fparain (Committer).
PR Review: https://git.openjdk.org/valhalla/pull/2064#pullrequestreview-3775127267
PR Review Comment: https://git.openjdk.org/valhalla/pull/2064#discussion_r2776114877
More information about the valhalla-dev
mailing list