[lworld] RFR: 8377327: [lworld] SA tests fail with --enable-preview

Coleen Phillimore coleenp at openjdk.org
Mon Feb 9 21:51:11 UTC 2026


On Mon, 9 Feb 2026 10:22:29 GMT, Paul Hübner <phubner at openjdk.org> wrote:

>> This set of SA tests fail because SA tries to parse field layouts.  With Valhalla there is new field info in the field stream, which is used when --enable-preview is used since some fields are flattened.  This adds minimal support for that.
>> 
>> Tested with tier1-4.
>
> test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSize.java line 70:
> 
>> 68:                                                 "java.lang.String",
>> 69:                                                 "java.lang.Thread",
>> 70:                                                 "java.lang.Byte"
> 
> Can we introduce a TestInlineKlassSize which adds a regression test for byte? I don't mind if this is done as a follow-up.

The test would have to differ if --enable-preview.  I don't think we should add any more SA work since it will someday be replaced.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2064#discussion_r2783407767


More information about the valhalla-dev mailing list