[lworld] RFR: 8375306: [lworld] Investigate alternatives to flatArrayOopDesc::obj_at implementation [v2]
Coleen Phillimore
coleenp at openjdk.org
Mon Feb 9 22:03:29 UTC 2026
On Fri, 6 Feb 2026 19:49:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Frederic Parain has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>>
>> - Comments update
>> - Rename new_default_refArray to new_refArray with overload
>> - Fixes issues mentioned in reviews
>> - Remove force_refarray and add array klass creation from ArrayDescription
>> - Fix merge
>> - Merge remote-tracking branch 'upstream/lworld' into refarray_factory
>> - Revert foreign methods signature changes
>> - Foreign API and other fixes
>> - CI fixes
>> - More fixes in serviceability code
>> - ... and 2 more: https://git.openjdk.org/valhalla/compare/dbed07f5...bd5f33d0
>
> src/hotspot/share/memory/oopFactory.cpp line 123:
>
>> 121: refArrayOop oopFactory::new_refArray(Klass* klass, int length, ArrayKlass::ArrayProperties properties, TRAPS) {
>> 122: ArrayKlass* array_type = klass->array_klass(CHECK_NULL);
>> 123: ObjArrayKlass* oak = ObjArrayKlass::cast(array_type)->klass_with_properties(properties, true, CHECK_NULL);
>
> I'm having trouble understanding this "force_refarray" parameter.
Stefan's suggestion is nice, and a lot clearer to me.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2033#discussion_r2775760708
More information about the valhalla-dev
mailing list