[lworld] RFR: 8377451: [lworld] Add ValuePayload abstraction

Frederic Parain fparain at openjdk.org
Mon Feb 9 22:05:15 UTC 2026


On Mon, 9 Feb 2026 13:27:54 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> src/hotspot/share/oops/inlineKlassPayload.hpp line 47:
>> 
>>> 45: private:
>>> 46:   template <typename Holder> struct StorageImpl {
>>> 47:     mutable Holder _holder;
>> 
>> I'm a little bit unsure about using `holder` as a name for the container object. In the runtime code `holder` often means the class that keeps metadata alive. Could this be `_object`, `_base`, `_container`, or something like that?
>> 
>> Maybe `is_raw` could also get a name that makes the connection between this property and the `holder`?
>
> Hmm. I agree. I see pros and cons. Let us see if we can discuss this one offline as well.

The terminology we have used so far in Valhalla was the "container".

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2784456736


More information about the valhalla-dev mailing list