[lworld] RFR: 8377451: [lworld] Add ValuePayload abstraction [v8]
Axel Boldt-Christmas
aboldtch at openjdk.org
Fri Feb 13 13:13:13 UTC 2026
On Fri, 13 Feb 2026 12:57:28 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> I actually look at this code periodically and don't really like scrolling down 256 lines to get to interesting parts. This code doesn't change so the merge with valhalla would be zero if it was 4 bytecodes per line. See if @shipilev has a differing opinion. Sorry for only commenting on the style nit but I found this jarring.
>
> Actually I wonder if there's a performance benefit to this case label implementation anymore. It was added when there was once a hope of replacing the template interpreter with this one.
> This code doesn't change so the merge with valhalla would be zero if it was 4 bytecodes per line.
I am confused to what this means?
This code must change with Valhalla as it adds two new internal bytecodes `fast_vgetfield` and `fast_vputfield`.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2068#discussion_r2804132169
More information about the valhalla-dev
mailing list