[lworld] RFR: 8373825: [lworld] ForwardingFileManager always closes its delegate leading to ClosedFileSystemException in TestOriginatingElements [v6]

[Roger Riggs]

On Fri, 13 Feb 2026 12:53:12 GMT, David Beaumont <duke at openjdk.org> wrote:

>> Allow users of Toolbox.MemoryFileManager to specify if the delegate file manager should also be closed when it is closed.
>> 
>> This fixes a use-after-close bug in TestOriginatingElements, where the system file manager and wrapping memory file manager have different, nested, lifetimes resulting in an early call to close the system file manager when the wrapper is closed, causing subsequent legitimate use of the system file manager to fail.
>> 
>> This wasn't noticed before now since the system file manager was using the singleton JRT file-system in which "close" does nothing. Now it's using a properly scoped instance of the JRT file-system which can be closed.
>
> David Beaumont has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
> 
>  - Merge branch 'lworld' into jdk_8373825_ffm/squashed
>  - revert forwarding file manager
>  - Remove extraneous problem list entry
>  - Reworking to simplify
>    
>    * Problem list
>    * temp commit
>    * add @since for new method
>    * tidy and restore eagerly removed not-actually-dead code
>    * Allow callers to decide if delgate file manager should be closed
>  - Merge branch 'lworld' into jdk_8373825_ffm/squashed
>  - add @since for new method
>  - undo reformatting
>  - tidy and restore eagerly removed not-actually-dead code
>  - Allow callers to decide if delgate file manager should be closed

looks ok

-------------

Marked as reviewed by rriggs (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/1810#pullrequestreview-3797397786