[lworld] RFR: 8375306: [lworld] Investigate alternatives to flatArrayOopDesc::obj_at implementation [v3]

[Frederic Parain]

On Fri, 13 Feb 2026 08:28:07 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix search of specific array klass
>
> src/hotspot/share/classfile/classLoader.cpp line 994:
> 
>> 992:   refArrayOop r = oopFactory::new_refArray(vmClasses::String_klass(),
>> 993:                                                    loaded_class_pkgs->length(),
>> 994:                                                    CHECK_NULL);
> 
> Suggestion:
> 
>   refArrayOop r = oopFactory::new_refArray(vmClasses::String_klass(),
>                                            loaded_class_pkgs->length(),
>                                            CHECK_NULL);

Fixed

> src/hotspot/share/interpreter/bootstrapInfo.cpp line 192:
> 
>> 190:     refArrayOop args_oop = oopFactory::new_refArray(vmClasses::Object_klass(),
>> 191:                                                             _argc,
>> 192:                                                             CHECK);
> 
> Suggestion:
> 
>     refArrayOop args_oop = oopFactory::new_refArray(vmClasses::Object_klass(), CHECK);

Fixed

> src/hotspot/share/oops/klass.cpp line 1077:
> 
>> 1075: 
>> 1076: #ifdef ASSERT
>> 1077: void Klass::validate_array_description(ArrayDescription& ad) {
> 
> This probably should be:
> Suggestion:
> 
> void Klass::validate_array_description(const ArrayDescription& ad) {

Fixed

> src/hotspot/share/prims/jvm.cpp line 1494:
> 
>> 1492:     refArrayOop res = oopFactory::new_refArray(vmClasses::Class_klass(),
>> 1493:                                                        members,
>> 1494:                                                        CHECK_NULL);
> 
> Suggestion:
> 
>     refArrayOop res = oopFactory::new_refArray(vmClasses::Class_klass(), members, CHECK_NULL);

Fixed

> src/hotspot/share/prims/jvm.cpp line 1968:
> 
>> 1966:     refArrayOop r = oopFactory::new_refArray(vmClasses::Class_klass(),
>> 1967:                                                      length + 1,
>> 1968:                                                      CHECK_NULL);
> 
> Suggestion:
> 
>     refArrayOop r = oopFactory::new_refArray(vmClasses::Class_klass(), length + 1, CHECK_NULL);
> 
> or:
> 
> Suggestion:
> 
>     refArrayOop r = oopFactory::new_refArray(vmClasses::Class_klass(),
>                                              length + 1,
>                                              CHECK_NULL);

Fixed

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2033#discussion_r2805588884
PR Review Comment: https://git.openjdk.org/valhalla/pull/2033#discussion_r2805593959
PR Review Comment: https://git.openjdk.org/valhalla/pull/2033#discussion_r2805595567
PR Review Comment: https://git.openjdk.org/valhalla/pull/2033#discussion_r2805597563
PR Review Comment: https://git.openjdk.org/valhalla/pull/2033#discussion_r2805599146