[lworld] RFR: 8378000: [lworld] Move ArrayProperties to its own class [v2]
Joel Sikström
jsikstro at openjdk.org
Mon Feb 16 15:03:58 UTC 2026
> Hello,
>
> We should consider moving the enum ArrayProperties from ArrayKlass to its own class, ArrayProperties. In addition to making the code easier to read and understand, this allows us to have explicit setters/getters, replacing the bit-fiddling expressions that are used in many places. The ArrayProperties-specific methods in ArrayKlass have been moved to be methods in the new ArrayProperties class instead.
>
> Perhaps the most controversial change in this PR is the removal of `ArrayKlass::ArrayProperties::DEFAULT` in favor of using a default constructor for ArrayProperties. The semantics are still the same, i.e., asking `.is_null_restricted()` or `.is_non_atomic()` will be false for the default constructed property. With this I've also removed the unused fields from ArrayProperties (DUMMY and comments).
>
> I did consider using define macros to generate enum+getters+setters, but I opted for the stamped-out version instead.
>
> Testing:
> * Running through tier1-2
Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
Braces around if-statement
-------------
Changes:
- all: https://git.openjdk.org/valhalla/pull/2114/files
- new: https://git.openjdk.org/valhalla/pull/2114/files/70085f44..019d164a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=valhalla&pr=2114&range=01
- incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2114&range=00-01
Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/valhalla/pull/2114.diff
Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2114/head:pull/2114
PR: https://git.openjdk.org/valhalla/pull/2114
More information about the valhalla-dev
mailing list