[lworld] RFR: 8377775: [lworld] compiler/ciReplay/TestInliningProtectionDomain.java still fails

[Tobias Hartmann]

On Mon, 16 Feb 2026 08:03:43 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

> ## Issue
> 
> The test `compiler/ciReplay/TestInliningProtectionDomain.java` still fails with `--enable-preview` even when using `java.lang.Record` as return class.
> 
> ## Causes
> 
> `java.lang.Record` is part of the migrated value classes that are added to the class loader if _enable preview_ is on and consequently it gets resolved early, making `ProtectionDomainTestNoOtherCompilationPrivate` fail.
> 
> ## Fix
> To avoid further potential issues (with another lib class that could potentially be loaded early in the future) I replaced the `Record` return type with a new test-local `class SigType {}` in the three `bar()` methods. Additionally the private-case replay assertion had to be updated to expect `unloaded signature classes` instead of `disallowed by ciReplay` (`Record` was resolved early and inlining was explicitly denied by replay. `SigType` is simply not resolved). The purpose of the test (that replay compilation produces the same inlining outcome as the normal run) should still be met.
> 
> ## Testing
> Tier 1-3+

Third time's the charm - looks good to me! 😄

-------------

Marked as reviewed by thartmann (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/2113#pullrequestreview-3809206016