[lworld] RFR: 8377162: [lworld] getResourceAsStream() doesn't work in preview mode for exploded images [v2]
David Beaumont
duke at openjdk.org
Tue Feb 17 11:20:03 UTC 2026
On Tue, 17 Feb 2026 11:17:06 GMT, David Beaumont <duke at openjdk.org> wrote:
>> Allow exploded module readers created for exploded system images to support preview mode.
>
> David Beaumont has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'lworld' into jdk_8377162_exploded_modules/squashed
> - revert unnecessary filter in ModulePatcher
> - Latest version
> - Limit awareness of preview resources to system modules only.
>
> * limit preview handling
> * Patch ModuleReaderTest from mainline
> - Preview mode for exploded system module readers
>
> * with better flag plumbing
> * Simpler approach with linked hash set
> * Revert weird import change
> * First cut at a preview aware module reader for exploded builds
> * Test for partiy of JRT file-system and class resources in preview mode
test/jdk/jdk/internal/jrtfs/JrtFileSystemClassParityTest.java line 1:
> 1: /*
The issue here is that this test is only meaningful if run via exploded-test, so I'm not happy submitting this directly (since it would have passed with the old code too). I want to write a unit test that directory creates and inspects an on-disk module in preview mode, but that needs a whitebox test since it needs access to the package access factory method.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2032#discussion_r2764640925
More information about the valhalla-dev
mailing list