[lworld] RFR: 8378105: [lworld] [REDO] Follow up 8329433 for Valhalla entry points in nmethod
Manuel Hässig
mhaessig at openjdk.org
Wed Feb 18 09:09:41 UTC 2026
On Wed, 18 Feb 2026 08:30:16 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
>> src/hotspot/share/code/nmethod.cpp line 1454:
>>
>>> 1452: };
>>> 1453:
>>> 1454: _osr_entry_point = relocate_address(nm._osr_entry_point);
>>
>> It becomes unclear whether it's worth having this lambda. I don't think it has other usage. It is heavy as a C++ lambda, it gives a name... No strong opinion. Feel free to ignore.
>
> Good catch! It would be more useful if we defined it in the header and then use it to define the `*entry_point` methods corresponding to the `*entry_offset` fields in terms of it.
Never mind my last comment, I misunderstood the lambda. I will go ahead and remove the lambda since it only has one use.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2123#discussion_r2821175902
More information about the valhalla-dev
mailing list