[lworld] RFR: 8377162: [lworld] getResourceAsStream() doesn't work in preview mode for exploded images [v2]

[Alan Bateman]

On Tue, 17 Feb 2026 11:19:57 GMT, David Beaumont <duke at openjdk.org> wrote:

>> Allow exploded module readers created for exploded system images to support preview mode.
>
> David Beaumont has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'lworld' into jdk_8377162_exploded_modules/squashed
>  - revert unnecessary filter in ModulePatcher
>  - Latest version
>  - Limit awareness of preview resources to system modules only.
>    
>    * limit preview handling
>    * Patch ModuleReaderTest from mainline
>  - Preview mode for exploded system module readers
>    
>    * with better flag plumbing
>    * Simpler approach with linked hash set
>    * Revert weird import change
>    * First cut at a preview aware module reader for exploded builds
>    * Test for partiy of JRT file-system and class resources in preview mode

test/jdk/java/lang/module/ModuleReader/ModuleReaderTest.java line 269:

> 267:     }
> 268: 
> 269:     private static String assertUtf8Resource(ModuleReader reader, String name) throws IOException {

This method is very confusing. Maybe replace it with two method. One to test the ModuleReader methods, the other to return the contents of the the resource as a String.

test/jdk/java/lang/module/ModuleReader/ModuleReaderTest.java line 289:

> 287:     @Test
> 288:     public void testModularJar() throws IOException {
> 289:         Path dir = Utils.createTempDirectory("mlib");

Just curious why you changed this as this test should not need to the Utils.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2032#discussion_r2823806765
PR Review Comment: https://git.openjdk.org/valhalla/pull/2032#discussion_r2823809650