[lworld] RFR: 8376778: [lworld] Ideal verification fails with "Need to remove from hash before changing edges" for various tests [v2]

[Benoît Maillard]

> This PR addresses several missed optimizations linked to `InlineType` nodes. These failures were originally caught during testing in `compiler/valhalla/inlinetypes/TestArrays.java` and `compiler/valhalla/inlinetypes/TestNullableInlineTypes.java`. I noticed there were two distinct cases in these tests and extracted reproducers.
> 
> The first case is a missed notification in `add_users_of_use_to_worklist` when we have nested `InlineType` nodes and we want to use the base oop if fields are loaded from memory. Since the structure might be nested, we need to add all the users in a recursive fashion.
> 
> The other case happens when we call `InlineTypeNode::buffer` during parsing. In `InlineTypeNode::Ideal`, we search re-allocation of an inlintype and attempt to remove them. Since this optimization hides behind the `can_reshape` flag, we need to make sure that the node gets added to the worklist after calling `PhaseGVN::transform`.
> 
> ### Testing
> - [x] GitHub Actions
> - [x] tier1-3, plus some internal testing
> 
> Thank you for reviewing!

Benoît Maillard has updated the pull request incrementally with one additional commit since the last revision:

  Remove commented code

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2135/files
  - new: https://git.openjdk.org/valhalla/pull/2135/files/4be59931..d6262ad0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2135&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2135&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/valhalla/pull/2135.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2135/head:pull/2135

PR: https://git.openjdk.org/valhalla/pull/2135