[lworld] RFR: 8378244: [lworld] Use guarantee instead of assert for Load/StoreNode construction

[Tobias Hartmann]

On Thu, 19 Feb 2026 12:28:02 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> [JDK-8364191](https://bugs.openjdk.org/browse/JDK-8364191) replaced two `ShouldNotReachHere()` with asserts. Let's use a guarantee instead to make sure we also fail in release builds and keep our static analysis tools happy.
> 
> Thanks,
> Tobias

Thanks for the review Quan Anh!

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2136#issuecomment-3927107615