[lworld] RFR: 8378186: [lworld] Assign default values and minor cleanup

Coleen Phillimore coleenp at openjdk.org
Thu Feb 19 13:35:52 UTC 2026


On Wed, 18 Feb 2026 17:22:32 GMT, Dan Heidinga <heidinga at openjdk.org> wrote:

> This provides a default value for some locals so it's obvious they are always set and does some minor cleanup.

A couple of minor suggestion/nits, otherwise good.

src/hotspot/share/classfile/stackMapFrame.cpp line 51:

> 49: 
> 50: void StackMapFrame::unsatisfied_strict_fields_error(InstanceKlass* klass, int bci) {
> 51:   /* Default these to `<Unknown>` as they will be replace with the correct

Suggestion:

  /* Default these to `<Unknown>` as they will be replaced with the correct

src/hotspot/share/classfile/stackMapFrame.cpp line 54:

> 52:    * values by the `find_unset` lambda as we only call this code when
> 53:    * an error has already been determined.  This just provides a safe
> 54:    * obvious fallback value

Suggestion:

   * obvious fallback value.

-------------

PR Review: https://git.openjdk.org/valhalla/pull/2130#pullrequestreview-3825957342
PR Review Comment: https://git.openjdk.org/valhalla/pull/2130#discussion_r2827927760
PR Review Comment: https://git.openjdk.org/valhalla/pull/2130#discussion_r2827929751


More information about the valhalla-dev mailing list