[lworld] RFR: 8378186: [lworld] Assign default values and minor cleanup [v2]

Dan Heidinga heidinga at openjdk.org
Thu Feb 19 18:17:13 UTC 2026


On Thu, 19 Feb 2026 18:09:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Dan Heidinga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> src/hotspot/share/classfile/stackMapFrame.cpp line 55:
> 
>> 53:    * an error has already been determined.  This just provides a safe
>> 54:    * obvious fallback value.
>> 55:    */
> 
> I'm sorry I have an additional comment.  This should be // comments not /* per hotspot coding convention.

There's already a `/* */` comment in the file.  Want me to fix both at the same time?

https://github.com/DanHeidinga/valhalla/blob/a2b8ae623bdf2564626e764e2802f109790ad7d6/src/hotspot/share/classfile/stackMapFrame.cpp#L313

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/2130#discussion_r2829403382


More information about the valhalla-dev mailing list