[lworld] RFR: 8377714: [lworld] Re-enable virtual thread tests [v2]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Fri Feb 20 00:32:59 UTC 2026
On Wed, 18 Feb 2026 20:56:28 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> On second thought, we are very much in the guts of this exact logic, so maybe if we wander here, we know, or we come from `remove_frame`'s neighborhood, so maybe it'd just be noise to add such a comment.
>
> I do like the idea of using a constant for 1 and 2 in the code that reads the pc and sp., like SP_OFFSET ?
I fixed the comment since it was missing to mention `rbp`, and added a reference to `MacroAssembler::remove_frame`. Also replaced constant 2 by `frame::metadata_words_at_bottom`.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2085#discussion_r2830797126
More information about the valhalla-dev
mailing list