[lworld] RFR: 8377162: [lworld] getResourceAsStream() doesn't work in preview mode for exploded images [v2]
Alan Bateman
alanb at openjdk.org
Fri Feb 20 11:25:23 UTC 2026
On Thu, 19 Feb 2026 20:11:28 GMT, David Beaumont <duke at openjdk.org> wrote:
>> Can you try changing the test descriptions so that the first run uses:
>>
>> @test id=no-enable-preview
>> @requires !java.enablePreview
>>
>> and the second run uses:
>>
>> @test id=enable-preview
>> @enablePreview
>>
>> I haven't tested it but it should mean the first run isn't selected when testing with preview features enabled (avoids adding it to ProblemList-enable-preview.txt). The second will avoid needing to explicitly use --enable-preview.
>>
>> ClassResourcesParityTest is probably okay in the sense that it tests that the resource lookup will locate the same class bytes as class loading .
>>
>> I think drop "default runtime" from the description as it hints of alternatives or some other install. The test will use the JDK under test, and this test exercises the file system view of this runtime. There is nothing images or exploded build specific.
>
> Done. Changes tested locally and I'll start a remote test run now.
> Oh blimey, how did I not think to add `-esa -ea`.
My comment was just an FYI that this is the default when executing tests with the make files so we usually don't need to put it in test descriptions like this.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2032#discussion_r2832741157
More information about the valhalla-dev
mailing list