[lworld] RFR: 8378273: [lworld] Use acmp map to detect oops for VarHandle [v3]
Roger Riggs
rriggs at openjdk.org
Fri Feb 20 21:45:23 UTC 2026
On Fri, 20 Feb 2026 21:28:51 GMT, Chen Liang <liach at openjdk.org> wrote:
>> VarHandle reflectively checks if a class has oops (and does it incorrectly by not filtering static fields). This information is easily accessible from acmp maps, and we should use that instead of spinning our custom logic.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Refactors per comment
src/java.base/share/classes/jdk/internal/value/ValueClass.java line 58:
> 56:
> 57: /// {@return whether the flat layout for fields of this type contains references}
> 58: /// Returns true if there is no flat layout for fields of the given type.
Confirming, will return true for an identityClass with only primitive fields?
The `hasOops` name might need to be more descriptive of the cases for an arbitrary class.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2143#discussion_r2835209015
More information about the valhalla-dev
mailing list