[lworld] RFR: 8377162: [lworld] getResourceAsStream() doesn't work in preview mode for exploded images [v5]
Alan Bateman
alanb at openjdk.org
Tue Feb 24 09:00:34 UTC 2026
On Thu, 19 Feb 2026 20:15:14 GMT, David Beaumont <duke at openjdk.org> wrote:
>> Allow exploded module readers created for exploded system images to support preview mode.
>
> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>
> Review feedback
test/jdk/jdk/internal/jrtfs/JrtFileSystemClassParityTest.java line 41:
> 39: * @test id=normal
> 40: * @summary Ensures the default runtime JRT file system has identical behavior
> 41: * in packaged or exploded builds compared to Class.getResourceAsStream().
The summary on ClassResourcesParityTest is clear that it tests the contents of class resources locates with jrtfs vs. Class.getResources.
The comment on JrtFileSystemClassParityTest is still a bit confusing (to me) as the test doesn't compare images vs. exploded build, instead it tests the mapping of jrt file paths to resources by ensuring that jrt and Class.getResourceAsStream get the same class bytes. So I think we should update this summary too, or maybe the two tests should be combined as they do overlap.
-------------
PR Review Comment: https://git.openjdk.org/valhalla/pull/2032#discussion_r2845447319
More information about the valhalla-dev
mailing list