[lworld] RFR: 8378232: [lworld] Redundant clause in ClassFileParser::verify_legal_class_modifiers [v2]

[Chen Liang]

On Tue, 24 Feb 2026 09:17:32 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

>> Hi everyone,
>> 
>> In `ClassFileParser::verify_legal_class_modifiers`, the `valid_value_class` bool had a redundant `!is_identity`. Since `is_identity` is already handled by short-circuiting earlier in the expression, that condition is always true in the remaining branch. This change removes the redundancy without changing behavior.
>> 
>> Testing:
>> - Tier 1
>
> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removed class_note

Marked as reviewed by liach (Committer).

-------------

PR Review: https://git.openjdk.org/valhalla/pull/2146#pullrequestreview-3847500662