[lworld] Integrated: 8378232: [lworld] Redundant clause in ClassFileParser::verify_legal_class_modifiers

Casper Norrbin cnorrbin at openjdk.org
Wed Feb 25 12:56:12 UTC 2026


On Fri, 20 Feb 2026 10:48:23 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

> Hi everyone,
> 
> In `ClassFileParser::verify_legal_class_modifiers`, the `valid_value_class` bool had a redundant `!is_identity`. Since `is_identity` is already handled by short-circuiting earlier in the expression, that condition is always true in the remaining branch. This change removes the redundancy without changing behavior.
> 
> Testing:
> - Tier 1

This pull request has now been integrated.

Changeset: 7bd1950b
Author:    Casper Norrbin <cnorrbin at openjdk.org>
Committer: Chen Liang <liach at openjdk.org>
URL:       https://git.openjdk.org/valhalla/commit/7bd1950bcd04af5b0f2bfb44f7c14cd6fc269051
Stats:     6 lines in 1 file changed: 0 ins; 5 del; 1 mod

8378232: [lworld] Redundant clause in ClassFileParser::verify_legal_class_modifiers

Reviewed-by: phubner, coleenp, liach

-------------

PR: https://git.openjdk.org/valhalla/pull/2146


More information about the valhalla-dev mailing list