[lworld] RFR: 8378672: [lworld] Consolidate a factory to create a GraphKit from a SafePointNode [v2]

Quan Anh Mai qamai at openjdk.org
Wed Feb 25 13:30:15 UTC 2026


> Hi,
> 
> I find it is a common occurrence that we want to expand a `SafePointNode` into a subgraph, and to do that we may need to create a `JVMState` ourselves, which may easily results in cumbersome errors because the kit state is not created properly. I tried using `GraphKit` to expand generate code after a `SafePointNode` (in particular, I tried to emit an uncommon trap there), which leads to this PR which consolidates the creation of a `GraphKit` from a `SafePointNode` that we want to use its debug state.
> 
> Please take a look and leave your reviews, thanks a lot.

Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:

  Collateral damage

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2163/files
  - new: https://git.openjdk.org/valhalla/pull/2163/files/500591fc..8c50fec9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2163&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2163&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/valhalla/pull/2163.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2163/head:pull/2163

PR: https://git.openjdk.org/valhalla/pull/2163


More information about the valhalla-dev mailing list