[lworld] Integrated: 8378672: [lworld] Consolidate a factory to create a GraphKit from a SafePointNode

Quan Anh Mai qamai at openjdk.org
Thu Feb 26 03:53:26 UTC 2026


On Wed, 25 Feb 2026 12:17:18 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> Hi,
> 
> I find it is a common occurrence that we want to expand a `SafePointNode` into a subgraph, and to do that we may need to create a `JVMState` ourselves, which may easily results in cumbersome errors because the kit state is not created properly. I tried using `GraphKit` to expand generate code after a `SafePointNode` (in particular, I tried to emit an uncommon trap there), which leads to this PR which consolidates the creation of a `GraphKit` from a `SafePointNode` that we want to use its debug state.
> 
> Please take a look and leave your reviews, thanks a lot.

This pull request has now been integrated.

Changeset: 1ea32590
Author:    Quan Anh Mai <qamai at openjdk.org>
URL:       https://git.openjdk.org/valhalla/commit/1ea32590f8eaf7982e8413bb10fc24377a024159
Stats:     46 lines in 3 files changed: 30 ins; 10 del; 6 mod

8378672: [lworld] Consolidate a factory to create a GraphKit from a SafePointNode

Reviewed-by: thartmann

-------------

PR: https://git.openjdk.org/valhalla/pull/2163


More information about the valhalla-dev mailing list