[lworld] RFR: 8378767: [lworld] Rename Makefile functions and variables related to preview mode

Roger Riggs rriggs at openjdk.org
Thu Feb 26 16:07:55 UTC 2026


On Thu, 26 Feb 2026 14:57:32 GMT, David Beaumont <duke at openjdk.org> wrote:

> Renames value class related functions and variables in Makefiles to reflect the more general use for preview mode classes/resources (where appropriate).
> 
> As preview mode is enabled in mainline builds, it will no longer be limited to value classes and their semantics.
> 
> After this change, the work "value" appears only once in the modified files (outside of comments) when defining GENERATED_PREVIEW_SUBDIRS.
> 
> This does change the `_the.$(MODULE).valueclasses` target to be `_the.$(MODULE).preview` but that should not be an issue.

Looks good.

make/common/Modules.gmk line 78:

> 76:     #
> 77: 
> 78: # Directories in which generated preview classes may exists.

typo "exists" -> "exist"

-------------

Marked as reviewed by rriggs (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/2175#pullrequestreview-3861932048
PR Review Comment: https://git.openjdk.org/valhalla/pull/2175#discussion_r2859862852


More information about the valhalla-dev mailing list